Add publishing-app custom dimension #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steventux
approved these changes
Aug 7, 2018
|
What's the reasoning behind the ordering change? Numerical ordering is really useful when looking up dimensions. |
cbaines
reviewed
Aug 7, 2018
| @@ -47,6 +47,7 @@ | |||
| 'navigation-legacy': {dimension: 30, defaultValue: 'none'}, | |||
| 'navigation-page-type': {dimension: 32, defaultValue: 'none'}, | |||
| 'political-status': {dimension: 7}, | |||
| 'publishing-app': {dimension: 89}, | |||
There was a problem hiding this comment.
I don't disagree with adding this, but I'm surprised that dimensions like format and schema-name don't separate Smart Answer pages from Transactions.
There was a problem hiding this comment.
@cbaines : smart-answers are an unusual case as their start page is being rendered as a transaction. The effect of this is that they are categorised as having a format and schema-name of transaction in GA.
added 2 commits
August 8, 2018 08:59
This will help differentiate smart-answers from transactions. Also moved navigation-legacy to respect the ordering by custom dimension value.
binaryberry
force-pushed
the
track-publishing-app
branch
from
fdc2ae6 to
5211d2e
Compare
|
@cbaines I hadn't noticed the custom dimension ordering! I thought it was a near-alphabetical ordering so wanted to improve it. Have removed that commit now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help differentiate smart-answers from transactions.
Related to alphagov/govuk_publishing_components#470.
https://trello.com/c/vhfMGngX/239-investigate-and-correct-smart-answer-google-analytics-tracking